Skip to content

Switch tsconfig settings for all packages in the repo#4101

Merged
JasonVMo merged 6 commits into
mainfrom
user/jasonvmo/configs-part-1
May 7, 2026
Merged

Switch tsconfig settings for all packages in the repo#4101
JasonVMo merged 6 commits into
mainfrom
user/jasonvmo/configs-part-1

Conversation

@JasonVMo
Copy link
Copy Markdown
Contributor

@JasonVMo JasonVMo commented May 7, 2026

Platforms Impacted

-- all

Description of changes

This change has two parts, the config level and package level.

At the config level:

  • add two new tsconfig.json files to scripts, a general one and a strict one
  • adds an exports map to scripts, and exposes those two files via the map
  • module/moduleResolution changed to "nodenext" this allows for requiring ESM which is supported in all versions of node we are using.
  • add erasableSyntaxOnly and noDefaultOverrides to the looser config

At the package level:

  • update tsconfig.json files to refer to the right source location
  • ensure we have a rootDir set if noEmit is not true. This is required to move forward with newer versions of tsgo/tsc.
  • standardize the outDir setting if it wasn't already set
  • ensure noEmit is declared at the package level when appropriate.

For packages the type errors fixed fall into several buckets:

  • add explicit overrides on class elements that are overridden.
  • get rid of const enums, generally replacing them with constant records. const enums are a typescript only thing.
  • get rid of some older forms to type assertions.

Comment thread apps/win32-81/src/index.js Outdated
Comment thread apps/win32/src/index.js Outdated
Comment thread packages/components/Menu/src/Menu/Menu.types.ts
Comment thread packages/utils/interactive-hooks/tsconfig.json Outdated
@JasonVMo JasonVMo merged commit 1598157 into main May 7, 2026
14 checks passed
@JasonVMo JasonVMo deleted the user/jasonvmo/configs-part-1 branch May 7, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants